Move NonLocalTOperator objects from Hamiltonian to Drivers #5137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ye-luo
force-pushed
the
refactor-ContextForSteps
branch
2 times, most recently
from
4d87314
to
f8dadb6
Compare
prckent
requested changes
Aug 22, 2024
| @@ -112,6 +111,16 @@ class QMCDriverNew : public QMCDriverInterface, public MPIObjectBase | |||
| //xmlNodePtr walker_logs_xml; | |||
|
|
|||
| protected: | |||
| class ContextForSteps | |||
| { | |||
There was a problem hiding this comment.
Can you add a description?
| {} | ||
|
|
||
| ///non local operator | ||
| NonLocalTOperator non_local_ops; |
There was a problem hiding this comment.
Can this be protected or private?
There was a problem hiding this comment.
ContextForSteps and its derived class are intended to be just a struct. Marking it private and adding an access function are unnecessary.
ye-luo
force-pushed
the
refactor-ContextForSteps
branch
from
6cfff41
to
96715a4
Compare
|
Test this please |
prckent
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review after #5135
Proposed changes
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
laptop
Checklist