Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup NonLocalTOperator constructor. #5143

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Cleanup NonLocalTOperator constructor. #5143

merged 2 commits into from
Aug 23, 2024

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Aug 22, 2024 •
edited
Loading

Proposed changes

Clean up the function thingsThatShouldBeInMyConstructor. Move the string to enum conversion into the input class.

What type(s) of changes does this code introduce?

  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

laptop

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@prckent
Copy link
Contributor

prckent commented Aug 23, 2024

Test this please

@prckent prckent enabled auto-merge August 23, 2024 17:39
PDoakORNL
PDoakORNL approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@PDoakORNL PDoakORNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prckent prckent merged commit ea7ecc5 into QMCPACK:develop Aug 23, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prckent prckent prckent approved these changes

@PDoakORNL PDoakORNL PDoakORNL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ye-luo @prckent @PDoakORNL