Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov configuration: specifically ignore test files #5153

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

prckent
Copy link
Contributor

@prckent prckent commented Aug 28, 2024

Proposed changes

Specifically including the test files in the search pattern works. Based on https://docs.codecov.com/docs/ignoring-paths

What type(s) of changes does this code introduce?

  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

None

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • NA. Code added or changed in the PR has been clang-formatted
  • NA. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • NA. Documentation has been added (if appropriate)

@prckent prckent changed the title [WIP] codecov configuration: specifically ignore test files codecov configuration: specifically ignore test files Aug 28, 2024
@ye-luo
Copy link
Contributor

ye-luo commented Aug 28, 2024

Please also include hpp to disappear
https://app.codecov.io/gh/QMCPACK/qmcpack/pull/5153/tree/src/Containers/tests

@ye-luo
Copy link
Contributor

ye-luo commented Aug 28, 2024

Test this please

@ye-luo ye-luo enabled auto-merge August 28, 2024 17:46
@ye-luo ye-luo merged commit b38794c into QMCPACK:develop Aug 28, 2024
37 of 39 checks passed
@prckent prckent deleted the morecovcfg branch September 19, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants