Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase C 1x1x1 pp non-local error bar in short test #5176

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

prckent
Copy link
Contributor

@prckent prckent commented Sep 20, 2024

Proposed changes

Fix an occasional failure in short-diamondC_1x1x1_pp-vmc_sdj-1-16-nonlocalecp

https://cdash.qmcpack.org/tests/4271226

What type(s) of changes does this code introduce?

  • Bugfix
  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

None

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • NA. Code added or changed in the PR has been clang-formatted
  • NA. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • NA. Documentation has been added (if appropriate)

@prckent prckent changed the title Increase si 1x1x1 pp non-local error bar in short test Increase C 1x1x1 pp non-local error bar in short test Sep 20, 2024
@prckent
Copy link
Contributor Author

prckent commented Sep 20, 2024

Test this please

@prckent
Copy link
Contributor Author

prckent commented Sep 20, 2024

Hmm, ntest_nexus_pwscf_simulation failure, unrelated to this PR. Possibly occurring because the nexus tests run in the source and not build directories, causing issues if multiple tests are running simultaneously. Will simply retrigger the failed tests.

@prckent prckent merged commit 0a97591 into QMCPACK:develop Sep 20, 2024
42 of 43 checks passed
@prckent prckent deleted the fixnl branch September 24, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants