Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase C 2x2x1 Gaussian variance tolerance in short test #5177

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

prckent
Copy link
Contributor

@prckent prckent commented Sep 20, 2024

Proposed changes

Fix rare failure in short-diamondC_2x1x1-Gaussian_pp_cplx_ground_MSD-1-16-variance
https://cdash.qmcpack.org/tests/4284430

Notably we have not had to change the test values on the total energy etc. A bit more noise on the variance is acceptable imo.

What type(s) of changes does this code introduce?

  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

None

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • NA. Code added or changed in the PR has been clang-formatted
  • NA. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • NA. Documentation has been added (if appropriate)

@prckent
Copy link
Contributor Author

prckent commented Sep 20, 2024

Test this please

@prckent prckent merged commit 024a7d4 into QMCPACK:develop Sep 20, 2024
38 of 39 checks passed
@prckent prckent deleted the fixC211var branch September 20, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants