Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase short-bccH_1x1x1_ae-vmc-all-nodrift_sdj-1-16-totenergy error #5182

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

prckent
Copy link
Contributor

@prckent prckent commented Sep 23, 2024

Proposed changes

https://cdash.qmcpack.org/tests/4363516

Address rare statistical failure in short-bccH_1x1x1_ae-vmc-all-nodrift_sdj-1-16-totenergy with increased error bar

e.g. Clang18 build gave:

Tests for series 0
  Testing quantity: LocalEnergy
    reference mean value     :  -1.83403200
    reference error bar      :   0.00030000
    computed  mean value     :  -1.83527856
    computed  error bar      :   0.00052208
    pass tolerance           :   0.00090000  (  3.00000000 sigma)
    deviation from reference :  -0.00124656  ( -4.15519995 sigma)
    error bar of deviation   :   0.00060214
    significance probability :   0.99996748  (gaussian statistics)
    status of this test      :   fail

Test status: fail

What type(s) of changes does this code introduce?

  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

None

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • NA. Code added or changed in the PR has been clang-formatted
  • NA. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • NA. Documentation has been added (if appropriate)

@ye-luo
Copy link
Contributor

ye-luo commented Sep 23, 2024

Test this please

@ye-luo ye-luo merged commit 4892a5a into QMCPACK:develop Sep 23, 2024
38 of 39 checks passed
@prckent prckent deleted the bccHerr branch September 24, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants