Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase short-diamondC_1x1x1_pp-dmc_sdj-1-16-kinetic error #5185

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

prckent
Copy link
Contributor

@prckent prckent commented Sep 24, 2024

Proposed changes

https://cdash.qmcpack.org/tests/4512639

Fix occasional failure in DMC kinetic energy test.

Tests for series 1
  Testing quantity: Kinetic
    reference mean value     :  11.48570000
    reference error bar      :   0.02310000
    computed  mean value     :  11.55687790
    computed  error bar      :   0.02252998
    pass tolerance           :   0.06930000  (  3.00000000 sigma)
    deviation from reference :   0.07117790  (  3.08129424 sigma)
    error bar of deviation   :   0.03226778
    significance probability :   0.99793883  (gaussian statistics)
    status of this test      :   fail

Test status: fail

What type(s) of changes does this code introduce?

  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

None

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • NA. Code added or changed in the PR has been clang-formatted
  • NA. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • NA. Documentation has been added (if appropriate)

@prckent prckent changed the title Increase short-diamondC_1x1x1_pp-dmc_sdj-1-16-kinetic K.E. error Increase short-diamondC_1x1x1_pp-dmc_sdj-1-16-kinetic error Sep 24, 2024
@ye-luo
Copy link
Contributor

ye-luo commented Sep 24, 2024

Test this please

@ye-luo ye-luo merged commit ec3d0bd into QMCPACK:develop Sep 24, 2024
39 of 40 checks passed
@prckent prckent deleted the fixc111dmcke branch September 24, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants