-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger submission workflow on issue edit and re-opening #453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just re-activated the trigger on the comment !redo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also neeed to edit the permission on those lines :
https://github.com/qiskit-community/ecosystem/blob/051fa51214c913d0b262663be560fb384c1f5847/.github/workflows/ecosystem-submission.yml#L25-L27
I'm not sure the first rule is working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to make it on edited
and reopened
you also need ot changed the if rules :
https://github.com/qiskit-community/ecosystem/blob/3c1d4873fa42dd3d79da44367d9a304b09bcf32e/.github/workflows/ecosystem-submission.yml#L21-L24
I think you can just deleted everything after filter on the name and just keep startsWith(github.event.issue.title, '[Submission]:')
…s/ecosystem into fh-workflow-triggers
@mickahell thanks! |
If you want to test it I can create an issue on your fork and then edit it to see if it's trigger correctly |
You just need to put your branch as default branch in your fork |
@mickahell, thanks – done |
I'll do it a bit later |
You need to activate the issues in your fork. They are unable by default @frankharkins |
Oops sorry, should work now |
Issue link : frankharkins#2 The actions start well by opening and editing the issue. Tests for me is well done ✅ For me everything is ok @frankharkins :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@mickahell thank you! |
Summary
This should make edits to submission issues update the submission PR. Should also allow us to close and reopen issues to refresh the submission PRs.