Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '_No response_' tag #454

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Conversation

frankharkins
Copy link
Member

Summary

If no tags are selected in the issue template, the labels field is ['_No response_']. This PR replaces this edge case with an empty list.

Fixes #319.

Copy link
Collaborator

@mickahell mickahell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can also add the mandatory of the field in the issue :)

just need adding to the file : https://github.com/qiskit-community/ecosystem/blob/main/.github/ISSUE_TEMPLATE/submission.yml?plain=1 :

    validations:
      required: true

ecosystem/utils/submission_parser.py Show resolved Hide resolved
@frankharkins
Copy link
Member Author

Do you think we should require tags? I'll ask the team what they think too

Copy link
Collaborator

@mickahell mickahell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point of view, it always gonna have a tag for any project. So it could be easy to put it mandatory.

Wait for your team feedback what does they thing about it :)

Every else looks good to me 🚀

@frankharkins
Copy link
Member Author

frankharkins commented Jul 28, 2023

For now, we won't make tags mandatory, but we will encourage selecting tags and work with submitters to add new tags if they feel that none fit their project.

(Basically, we want all projects to have tags, but we won't force it at the issue stage.)

@frankharkins frankharkins merged commit 0a3fdab into Qiskit:main Jul 28, 2023
4 checks passed
@frankharkins frankharkins deleted the fh-empty-tags branch July 28, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submission form: mandatory tags
2 participants