-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancel #1318
Cancel #1318
Conversation
Signed-off-by: Akihiko Kuroda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akihikokuroda do you want to have it as intermediate step before figuring out solution without service passing?
I would agree as a solution by now at least. |
So far, I couldn't get the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my part LGTM, @akihikokuroda . Thank you!
@IceKhan13 I'll open an issue for the service less solution. #1327 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akihikokuroda thank you!
Summary
fix #1317
Details and comments
The optional
service
argument is added to thejob.stop()
method. When theservice
is provided, thestop
method stops the pending backend runtime jobs in addition to the middleware job.