Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel #1318

Merged
merged 5 commits into from
May 10, 2024
Merged

Cancel #1318

merged 5 commits into from
May 10, 2024

Conversation

akihikokuroda
Copy link
Collaborator

Summary

fix #1317

Details and comments

The optional service argument is added to the job.stop() method. When the service is provided, the stop method stops the pending backend runtime jobs in addition to the middleware job.

gateway/api/views.py Outdated Show resolved Hide resolved
gateway/requirements.txt Outdated Show resolved Hide resolved
gateway/requirements.txt Outdated Show resolved Hide resolved
Copy link
Member

@IceKhan13 IceKhan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akihikokuroda do you want to have it as intermediate step before figuring out solution without service passing?

@Tansito
Copy link
Member

Tansito commented May 9, 2024

@akihikokuroda do you want to have it as intermediate step before figuring out solution without service passing?

I would agree as a solution by now at least.

@akihikokuroda
Copy link
Collaborator Author

So far, I couldn't get the super user way. The token or service is required to cancel the job. The user has the service anyway so I added as the optional argument for stop method.

Copy link
Member

@Tansito Tansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my part LGTM, @akihikokuroda . Thank you!

@akihikokuroda
Copy link
Collaborator Author

akihikokuroda commented May 9, 2024

@akihikokuroda do you want to have it as intermediate step before figuring out solution without service passing?

@IceKhan13 I'll open an issue for the service less solution. #1327

Copy link
Member

@IceKhan13 IceKhan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akihikokuroda thank you!

@akihikokuroda akihikokuroda merged commit be8361a into Qiskit:main May 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancel runtime jobs when our job is stopped
3 participants