-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Function.get_jobs() #1406
add Function.get_jobs() #1406
Conversation
The |
It should be working from what I remember, yep |
It's a cloudpickle one. It must get broken when gateway moved to 3.11. |
Oh, maybe. Maybe we can fix it if we move everything to python 3.11. |
yeah, it's been failing for a couple of weeks now (this was as far back as I looked, but that was the end of the 1st page results) |
6666bbf
to
ea484fc
Compare
Can we add a test here too testing the client, Aki? https://github.com/Qiskit/qiskit-serverless/tree/main/tests/basic |
@Tansito Thanks for your review. I updated according to your comments. I couldn't make the function test in |
@akihikokuroda I saw that you were making changes, let me know if you want that I review something 👍 |
@Tansito Please review the changes. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of very minor things, but otherwise LGTM
Sorry @akihikokuroda , I was turning off fires today and I couldn't have more time to see this. I will try to take a final look before finish the day 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM everything, Aki. Thank you!
Summary
This the second part of #1400
Details and comments
This PR providers
Function.get_logs()
method that returns the job ids of jobs that executed thefunction
.