Create new cluster for each job execution #1500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul S. Schweigert <[email protected]>
|
We don't necessarily need this now, so will leave it up to reviewers on whether to merge this or close it. |
|
Actually, the docker test failure here seems legit, and since I think this falls into the "nice to have" bucket right now, I don't think it makes sense to spend the time to iron that issue out right now. |
|
The good thing at least is that right now in our cluster we are not allowing that: We are using one here so good. Anyway I will open an issue around this, thanks Paul! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create a new RayCluster each time we execute a job.
Details and comments
This will be better for resource management, as each job will get exactly the resources requested. Previously, if a user submitted two jobs they would run in the same cluster and sharing resources, so the resource requests wouldn't necessarily be honored exactly.
Plus, this will also be the default behavior after migrating to RayJobs (#1337), so its not something we weren't planning on doing eventually anyway.