sanitize title and provider input string #1504
Conversation
There was a problem hiding this comment.
@akihikokuroda is it possible to check for limit and offset values in jobs-list too?
https://github.com/Qiskit/qiskit-serverless/blob/main/gateway/api/views.py#L479
|
@Tansito I'm not sure if the PageNumberPagination handles by itself. Does DAST detect issue about it? If so, we can deal with it in a separate PR. |
|
@psschwei No, we don't. The query strings are almost passthrough to the gateway. |
gateway/api/utils.py
Outdated
| if name: | ||
| sanitized_name = "" | ||
| for c in name: | ||
| if c.isalnum() or c in ["_", "-", ":", "@", "/"]: |
There was a problem hiding this comment.
If this PR is only for title and provider we should only accept: ["_", "-"], WDYT?
There was a problem hiding this comment.
Maybe "/" in case we can receive: "provider/title" string, but I think we are not checking this here, right Aki?
There was a problem hiding this comment.
It is checking the "/" here. So we can accept "-", "_" and "/".
|
Let's try it! Thanks Aki 🎉 |
Summary
This PR adding the code that sanitizes the title and provider input string
Details and comments