Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy documentation in qiskit.org/ecosystem #843

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Mar 21, 2023

Similar to Qiskit/qiskit-aer#1748, see Qiskit/qiskit.org#3038 for more context

Summary

The Qiskit Ecosystem lives in qiskit.org/ecosystem and new place for qiskit related projects that are not technically Qiskit. This PR adds that destination for documentation deployment.

Details and comments

For now, a copy of the same docs in ecosystem would allow to have both q.o/documentation and q.o/ecosystem for testing that everything is fine. Once that's done, the CDN will redirects to the new location and the deploy to q.o/documentation can be removed.

@coveralls
Copy link

coveralls commented Mar 21, 2023

Pull Request Test Coverage Report for Build 4553753463

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 97.114%

Totals Coverage Status
Change from base Build 4549057948: 0.06%
Covered Lines: 13896
Relevant Lines: 14309

💛 - Coveralls

@mtreinish
Copy link
Member

For now, a copy of the same docs in ecosystem would allow to have both q.o/documentation and q.o/ecosystem for testing that everything is fine. Once that's done, the metapackage can create the redirects and the deploy to q.o/documentation can be removed.

I'm not sure I follow this step, is the plan you're doing to centralize the building of the redirects and remove the excludes here?: https://github.com/Qiskit/qiskit/blob/master/tools/other-builds.txt#L10 I assumed the plan was that we'd upload a redirect pages to q.o/documentation/rustworkx here and have them all point to q.o/ecosystem/rustworkx. Especially since the builds locally in this repository are able to build the redirect pages easily since they have the full source list available.

@1ucian0
Copy link
Member Author

1ucian0 commented Mar 21, 2023

Yes. My plan was to redirect q.o/documentation/rustworkx/<something> -> q.o/ecosystem/rustworkx/<something> from the metapackage. If I understood you correctly, it might be possible to be done at a different point (was it at CDN-level?).

@1ucian0
Copy link
Member Author

1ucian0 commented Mar 21, 2023

updating initial comment to talk about CDN instead of metapackage. Thanks!

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I'm thinking we should also remember to add the CDN edge function redirect for retworkx -> rustworkx too while we're updating it.

@mtreinish mtreinish added the automerge Queue a approved PR for merging label Mar 29, 2023
@mergify mergify bot merged commit 4c31946 into Qiskit:main Mar 29, 2023
@1ucian0 1ucian0 deleted the move_docs_to_ecosystem branch August 11, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants