Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add f2py section to porting guide #50

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

ngoldbaum
Copy link
Collaborator

No description provided.

@rgommers rgommers added the documentation Improvements or additions to documentation label Jul 24, 2024
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nathan! Great to have this support available now. Two minor textual comments.

docs/porting.md Outdated
$ python -m numpy.f2py -c code.f -m my_module --freethreading-compatible
```

If you know the extension is *not* thread safe, then you can force the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be necessary right, since that's the default already? If so, then it's better to leave this out I think.

Or do you recommend this for clarity only? If so, I suggest saying that explicitly.

docs/porting.md Outdated
=== "f2py"

Starting with NumPy 2.1.0 (only available via the nightly wheels or the
`main` branch as of right now), Fortran extension modules wrapped using
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Fortran extension modules" wording looks very slightly off to me, but I'm also having a hard time rewording it. Perhaps "extension modules containing f2py-wrapped Fortran code" works?

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ngoldbaum!

@rgommers rgommers merged commit 97a6f15 into Quansight-Labs:main Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants