Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ with common errors and how to deal with them #52

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

ngoldbaum
Copy link
Collaborator

Any other errors it would be good to mention?

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ngoldbaum! Looks good!

I left some comments about a few minor fixes.

docs/debugging.md Outdated Show resolved Hide resolved
docs/debugging.md Outdated Show resolved Hide resolved
docs/debugging.md Outdated Show resolved Hide resolved
docs/debugging.md Outdated Show resolved Hide resolved
docs/debugging.md Outdated Show resolved Hide resolved
docs/porting.md Outdated Show resolved Hide resolved
docs/debugging.md Outdated Show resolved Hide resolved
@rgommers rgommers added the documentation Improvements or additions to documentation label Jul 26, 2024
docs/debugging.md Outdated Show resolved Hide resolved
docs/debugging.md Outdated Show resolved Hide resolved
@rgommers
Copy link
Member

Any other errors it would be good to mention?

This looks good to me - nothing else comes to mind right now.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments were addressed, this looks ready. Thanks Nathan & all reviewers!

@rgommers rgommers merged commit b580d28 into Quansight-Labs:main Jul 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants