Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker requirement ci #468

Merged
merged 3 commits into from
Aug 4, 2024

Conversation

arjxn-py
Copy link
Contributor

@arjxn-py arjxn-py commented Aug 4, 2024

Follow up on #459
Related to #467
cc: @pmeier

Here's the issue surfaced upon failure on current changes: arjxn-py#12

@arjxn-py
Copy link
Contributor Author

arjxn-py commented Aug 4, 2024

We should merge this branch to test-ci branch and then manually trigger the docker requirement update workflow to test if it'll open issue on failure.

@pmeier pmeier merged commit 033dd8d into Quansight:test-ci Aug 4, 2024
21 checks passed
@pmeier
Copy link
Member

pmeier commented Aug 4, 2024

@arjxn-py
Copy link
Contributor Author

arjxn-py commented Aug 4, 2024

We'd also have to set GH_TOKEN in secrets. As it is required for both gh api & JasonEtco/create-an-issue@v2 action

We would also have to make sure that we don't open a PR from this branch until we're done testing as after opening the PR the workflow should not fail which will result in not surfacing an issue. cc: @pmeier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants