fix doc builds after recent changes #494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
added
area: documentation 📖
pmeier
commented
Aug 20, 2024
Comment on lines
+284
to
+285
| if not isinstance(input, collections.abc.Collection): | ||
| input = [input] |
There was a problem hiding this comment.
Driveby to also allow single documents.
| *, | ||
| source_storage: Union[Type[SourceStorage], SourceStorage], | ||
| assistant: Union[Type[Assistant], Assistant], | ||
| corpus_name: Optional[str], | ||
| corpus_name: Optional[str] = None, |
There was a problem hiding this comment.
@nenb I've added a default value here, because I don't want to force users to always set this one.
| "source_storage": source_storages.RagnaDemoSourceStorage.display_name(), | ||
| "assistant": DemoStreamingAssistant.display_name(), | ||
| "corpus_name": None, |
There was a problem hiding this comment.
We probably want to have this as default value as well.
There was a problem hiding this comment.
Is this still valid after your comments in #493?
|
Superseded by #498. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to get the CI green again on the
corpus-devbranch. We still need to add actual documentation for the changes we have made. I'll flag some of them below.