Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unexpected new line characters when pulling projects #344

Conversation

jhonabreul
Copy link
Collaborator

In some cases (only haven been able to reproduce it using the extension) the algorithm files are stored using windows new line separators, but the CLI works with '\n' when the files contents are in memory. This fixes this unexpected file content new line separators for those cases.

Closes #342

@jaredbroad
Copy link
Member

Thank you

@ghost
Copy link

ghost commented Jul 14, 2023 via email

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🍬

@Martin-Molinero Martin-Molinero merged commit 2cf234a into QuantConnect:master Jul 14, 2023
23 checks passed
@jhonabreul jhonabreul deleted the bug-342-unexpected-new-line-characters-on-pull branch July 17, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lean Cloud Pull Inserts New Empty Lines In Algorithm
3 participants