Fix: bug with default market in download #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes bug with default market name USA not being retrieved from the configuration file of data providers.
Related Pull Request
data downloadcommand to lean-cli for data retrieval #447Description:
This pull request addresses an issue where the default market name "USA" was not being fetched from the configuration file of data providers. The bug caused the system to use an incorrect default market name, leading to unexpected behavior in certain scenarios.
Changes Made:
Testing:
This fix has been thoroughly tested by running the updated code locally using the Lean development library. The testing process included verifying that the default market name is fetched correctly from the configuration file and that the system behaves as expected in various scenarios.
Outcome:
With this fix, the system now properly retrieves the default market name "USA" from the configuration file of data providers, resolving the bug and ensuring consistent behavior across different environments.