Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: More informative exception message in lean logs command #489

Merged

Conversation

Romazes
Copy link
Contributor

@Romazes Romazes commented Aug 15, 2024

Description

This pull request addresses an issue where the script could not locate the most recent log file for the specified mode, leading to a RuntimeError. The error message has been made more user-friendly by providing clearer instructions to the user on how to resolve the issue.

Changes Made:

  • Updated the RuntimeError exception message to be more descriptive and user-friendly.
  • The new message now suggests specifying the --project argument explicitly if the log file cannot be found.

Related Issue

Closes #463

Motivation and Context

The previous error message was less informative and could be confusing for users who are unfamiliar with the specific requirements of the script. By improving the clarity of the message, we aim to reduce the potential for user error and enhance the overall usability of the script. This change is particularly important for new users who might not be aware of the necessity of the --project argument when the log file is not found.

How Has This Been Tested?

image

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@Martin-Molinero Martin-Molinero merged commit 51968f6 into QuantConnect:master Aug 15, 2024
25 checks passed
@Romazes Romazes deleted the fix-463-lean-log-more-informative branch September 17, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lean log Without Options/Arguments Do Not Find Logs
2 participants