Feat: More informative exception message in lean logs command
#489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue where the script could not locate the most recent log file for the specified mode, leading to a
RuntimeError. The error message has been made more user-friendly by providing clearer instructions to the user on how to resolve the issue.Changes Made:
RuntimeErrorexception message to be more descriptive and user-friendly.--projectargument explicitly if the log file cannot be found.Related Issue
Closes #463
Motivation and Context
The previous error message was less informative and could be confusing for users who are unfamiliar with the specific requirements of the script. By improving the clarity of the message, we aim to reduce the potential for user error and enhance the overall usability of the script. This change is particularly important for new users who might not be aware of the necessity of the
--projectargument when the log file is not found.How Has This Been Tested?