Add setting up python home and environment variable checking #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Params Issue
Improve property access performance
- Converter with handle sending a python List to a method expecting a csharp enumerable. Adding unit test
…d-resolution Bug enumerable list method resolution
- Updating all projects to target net.50 - Remove domain test since it's not supported in net5.0
Update to net 5 0
…s do not need to be created. Comes in handy when having multiple python versions
There was a problem hiding this comment.
Thanks!
Similar to https://github.com/pythonnet/pythonnet/pull/1411/files which we haven't cherry-picked yet. Next release we can look into this 💯 and ship it, but would prefer to follow the behavior at root pythonnet/pythonnet to avoid unnecessary deviations though, rebase is already complex enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Checks to make sure the required environment variable is set. (PYTHONNET_PYDLL). It then takes the directory path and sets that on the PythonHome property of the engine. This allows the embedded python instance to use the specified path versus trying to find it through the OS environment.
Does this close any currently open issues?
#54
Any other comments?
At a minimum it will make initialization less likely to fail
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG