Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: docs maintenance (WIP) #740

Merged
merged 19 commits into from
Nov 27, 2024
Merged

MAINT: docs maintenance (WIP) #740

merged 19 commits into from
Nov 27, 2024

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Nov 2, 2024

This PR

  • updates theme for rtd
  • adds a setup and install section
  • adds information for contributing to the package

some of this information is migrated from organization website

@coveralls
Copy link

coveralls commented Nov 2, 2024

Coverage Status

coverage: 93.117%. remained the same
when pulling 0917b79 on improve-docs
into 494603d on main.

@mmcky mmcky changed the title MAINT: docs maintenance MAINT: docs maintenance (WIP) Nov 2, 2024
@mmcky mmcky added the in-work label Nov 2, 2024
@oyamad
Copy link
Member

oyamad commented Nov 6, 2024

I don't know what it is happening with the error with NumPy v2. The testing with NumPy v2 was introduced by #736. Something may be wrong in there...

@oyamad
Copy link
Member

oyamad commented Nov 10, 2024

The error should be resolved by #743.

@mmcky
Copy link
Contributor Author

mmcky commented Nov 24, 2024

thanks @oyamad

@mmcky mmcky closed this Nov 27, 2024
@mmcky mmcky reopened this Nov 27, 2024
-------------------

We try to maintain a simple and consistent format for inline documentation, known in the Python world as docstrings.
The format we use is known as :ref:`numpydoc<https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page no longer exists.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @oyamad migrating content at the moment from the QuantEcon org site and will proof read. Appreciate the comment.

@oyamad
Copy link
Member

oyamad commented Nov 27, 2024

@mmcky Could you add an instruction about how to install with conda? There was once a confusion: see #732 (comment).

@pep8speaks
Copy link

pep8speaks commented Nov 27, 2024

Hello @mmcky! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 151:1: W293 blank line contains whitespace

Comment last updated at 2024-11-27 04:33:18 UTC

@mmcky
Copy link
Contributor Author

mmcky commented Nov 27, 2024

thanks @oyamad once this passes green I think we can merge.

docs/source/contributing.rst Outdated Show resolved Hide resolved
docs/source/contributing.rst Outdated Show resolved Hide resolved
@mmcky
Copy link
Contributor Author

mmcky commented Nov 27, 2024

thanks for reviewing @oyamad -- merged all suggestions.

Copy link
Member

@oyamad oyamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmcky Thanks!

@mmcky
Copy link
Contributor Author

mmcky commented Nov 27, 2024

  • readthedocs is now configured to give build previews for all PRs. 🥳

@mmcky mmcky merged commit f214fdf into main Nov 27, 2024
11 checks passed
@mmcky mmcky deleted the improve-docs branch November 27, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants