Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: remove code-book and add download links #62

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Mar 28, 2024

This PR

  • removes the code-book
  • converts existing md files to ipynb files
  • provides a new notebooks page to link to github to download the notebook files for each chapter.
  • @mmcky to do a review and error check

Copy link

netlify bot commented Mar 28, 2024

👷 Deploy Preview for keen-wozniak-c08666 processing.

Name Link
🔨 Latest commit 3aa7074
🔍 Latest deploy log https://app.netlify.com/sites/keen-wozniak-c08666/deploys/6604f55e0816d900087b6db0

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for keen-wozniak-c08666 failed.

Name Link
🔨 Latest commit b0e478a
🔍 Latest deploy log https://app.netlify.com/sites/keen-wozniak-c08666/deploys/6621bc85222bbd0007c17c5f

@mmcky
Copy link
Contributor Author

mmcky commented Mar 28, 2024

@DrDrij can you help make this table look better in this context?

https://6604f5338a0863359318839a--keen-wozniak-c08666.netlify.app/notebooks

I copied the code from https://dp.quantecon.org/code.html but i think it doesn't look great when it is just a single line.

@mmcky mmcky marked this pull request as draft March 28, 2024 04:45
All I have don't here @mmcky is add a HTML table row between the first and second cell.
<tr><td>content cell 1</td><.tr>
<tr><td>content cell 2</td></tr>

I hope this is what you were after.
@github-actions github-actions bot temporarily deployed to commit March 28, 2024 20:45 Inactive
@DrDrij
Copy link
Member

DrDrij commented Mar 28, 2024

Hey @mmcky I hope you don't mind I went ahead and just committed the change to the table.

This lines I edited are here: https://github.com/QuantEcon/book-networks-public/pull/62/files#diff-1935b95de07be14d4bfa51e8b6d87a248e2194e7dc56a775ebbf0ac4cafef1d1R32

The update should visually look like this:
image

And the HTML markup just added the second cell onto a new table row so it went from:

                    <table class="alt" style="width:50%;">
                        <tbody>
                            <tr>
                                <td>Python</td><td><a href="https://github.com/QuantEcon/book-networks-public/tree/main/notebooks">Files on GitHub</a></td>
                            </tr>
                        </tbody>
                    </table>

And now is:

                    <table class="alt" style="width:50%;">
                        <tbody>
                            <tr>
                                <td>Python</td>
			    </tr>
			    <tr>
                                <td><a href="https://github.com/QuantEcon/book-networks-public/tree/main/notebooks">Files on GitHub</a></td>
                            </tr>
                        </tbody>
                    </table>

Hope this is what you were after!

@mmcky
Copy link
Contributor Author

mmcky commented Apr 1, 2024

thanks @DrDrij

@mmcky mmcky marked this pull request as ready for review April 19, 2024 00:36
@github-actions github-actions bot temporarily deployed to commit April 19, 2024 00:36 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Apr 19, 2024

  • update location from notebooks to ipynb but that link won't work until site is published (@mmcky check all links once new site is published)

@mmcky
Copy link
Contributor Author

mmcky commented Apr 19, 2024

@jstac this PR removes the code-book and replaces it with a static link to the collection of notebooks for each chapter. I don't see any collection of code in the book-networks repo so the source of truth are these notebooks as I understand.

https://github.com/QuantEcon/book-networks-public/tree/remove-code-book/ipynb

@jstac
Copy link
Collaborator

jstac commented Apr 19, 2024

@jstac this PR removes the code-book and replaces it with a static link to the collection of notebooks for each chapter. I don't see any collection of code in the book-networks repo so the source of truth are these notebooks as I understand.

https://github.com/QuantEcon/book-networks-public/tree/remove-code-book/ipynb

Thanks @mmcky. I don't think there are any corresponding notebooks in the private repo.

@mmcky
Copy link
Contributor Author

mmcky commented Jul 7, 2024

@jstac are you happy for this to be merged now?

The notebook link on

https://6621bc8f2253ce485588bfed--keen-wozniak-c08666.netlify.app/

won't work until this is merged as the assets are part of this PR.

@jstac
Copy link
Collaborator

jstac commented Jul 7, 2024

@mmcky Perhaps we can go ahead and merge, so that all the links work, and then iterate if we need to?

Could you please fix any failing tests that you need to and then merge?

@mmcky
Copy link
Contributor Author

mmcky commented Jul 8, 2024

thanks @jstac I will merge then review the page in full.

@mmcky mmcky merged commit 9927df8 into main Jul 8, 2024
2 of 6 checks passed
@mmcky mmcky deleted the remove-code-book branch July 8, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants