-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: remove code-book and add download links #62
Conversation
👷 Deploy Preview for keen-wozniak-c08666 processing.
|
❌ Deploy Preview for keen-wozniak-c08666 failed.
|
@DrDrij can you help make this table look better in this context? https://6604f5338a0863359318839a--keen-wozniak-c08666.netlify.app/notebooks I copied the code from https://dp.quantecon.org/code.html but i think it doesn't look great when it is just a single line. |
All I have don't here @mmcky is add a HTML table row between the first and second cell. <tr><td>content cell 1</td><.tr> <tr><td>content cell 2</td></tr> I hope this is what you were after.
Hey @mmcky I hope you don't mind I went ahead and just committed the change to the table. This lines I edited are here: https://github.com/QuantEcon/book-networks-public/pull/62/files#diff-1935b95de07be14d4bfa51e8b6d87a248e2194e7dc56a775ebbf0ac4cafef1d1R32 The update should visually look like this: And the HTML markup just added the second cell onto a new table row so it went from:
And now is:
Hope this is what you were after! |
thanks @DrDrij |
|
@jstac this PR removes the code-book and replaces it with a static link to the collection of notebooks for each chapter. I don't see any collection of code in the https://github.com/QuantEcon/book-networks-public/tree/remove-code-book/ipynb |
Thanks @mmcky. I don't think there are any corresponding notebooks in the private repo. |
@jstac are you happy for this to be merged now? The notebook link on https://6621bc8f2253ce485588bfed--keen-wozniak-c08666.netlify.app/ won't work until this is merged as the assets are part of this PR. |
@mmcky Perhaps we can go ahead and merge, so that all the links work, and then iterate if we need to? Could you please fix any failing tests that you need to and then merge? |
thanks @jstac I will merge then review the page in full. |
This PR
md
files toipynb
filesnotebooks
page to link to github to download the notebook files for each chapter.