MAINT: Use np.interp as supported by numba #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for incomparable-parfait-2417f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kp992
approved these changes
Mar 4, 2024
|
@kp992 thanks for review. If you could let me know you approve in the future that would be great (rather than merge). I will do some benchmarks to see if |
|
Okay, noted. Thanks @mmcky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from
interpolationpackage to usenp.interpas this is now supported directly bynumbahttps://numba.pydata.org/numba-doc/dev/developer/autogen_numpy_listing.html#numpy.interp
ref: QuantEcon/QuantEcon.py#722 and QuantEcon/QuantEcon.py#724