Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to inventory dynamics lecture #149

Merged
merged 7 commits into from
Mar 13, 2024
Merged

Updates to inventory dynamics lecture #149

merged 7 commits into from
Mar 13, 2024

Conversation

jstac
Copy link
Contributor

@jstac jstac commented Mar 13, 2024

Improved flow, used fori_loop instead of scan, removed kernel density estimator.

Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for incomparable-parfait-2417f8 ready!

Name Link
🔨 Latest commit 503f516
🔍 Latest deploy log https://app.netlify.com/sites/incomparable-parfait-2417f8/deploys/65f16a881b2a660008b2542b
😎 Deploy Preview https://deploy-preview-149--incomparable-parfait-2417f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 13, 2024

@github-actions github-actions bot temporarily deployed to pull request March 13, 2024 01:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 13, 2024 01:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 13, 2024 02:18 Inactive
@jstac
Copy link
Contributor Author

jstac commented Mar 13, 2024

@shlff Would you be willing to finish off this PR?

The remaining steps are to

  • change mu and sigma to greek letters in the code
  • change the last section (section 5.5.2) into an exercise

To change the last section into an exercise, the wording at the start of the section needs to be modified:

"Write a fori_loop version of the last function. See if you can increase the speed while generating a similar answer."

@shlff
Copy link
Member

shlff commented Mar 13, 2024

Thanks @jstac . I'd love to!

I'll work on it now and update it soon.

@github-actions github-actions bot temporarily deployed to pull request March 13, 2024 03:52 Inactive
@shlff shlff added the in-work label Mar 13, 2024
@github-actions github-actions bot temporarily deployed to pull request March 13, 2024 04:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 13, 2024 04:18 Inactive
@shlff
Copy link
Member

shlff commented Mar 13, 2024

Thanks @jstac . This PR is ready to review.

(I corrected some typos in my third commit)

@shlff shlff added ready and removed in-work labels Mar 13, 2024
@jstac
Copy link
Contributor Author

jstac commented Mar 13, 2024

Many thanks @shlff , nice work! Merging.

@jstac jstac merged commit 97cbc37 into main Mar 13, 2024
1 check passed
@jstac jstac deleted the update_inventory branch March 13, 2024 08:58
@github-actions github-actions bot temporarily deployed to pull request March 13, 2024 09:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants