[time_series_with_matrices] Update editorial suggestions #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Many thanks @SylviaZhaooo. I will update the code in this branch. |
mmcky
requested changes
Jun 28, 2024
|
this is currently failing the preview build due to it looks like we have made too many requests for anaconda. So I will need to wait 30min and try again. |
Co-authored-by: Matt McKay <[email protected]>
Co-authored-by: Matt McKay <[email protected]>
|
@SylviaZhaooo let me know if you would like to link up to discuss the intersphinx links for this PR. Cheers. |
The Interspinx is better and I changed another link as well. |
mmcky
requested changes
Jul 1, 2024
Co-authored-by: Matt McKay <[email protected]>
|
Can this be merged @mmcky ? It looks good to me. |
jstac
approved these changes
Jul 4, 2024
|
thanks for approval @jstac. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve most comments in #461.