-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ar1_processes] to [eigen_II] [heavy_tails][inequality]Example and spelling #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update_ar1_example; no spelling error.
This commit updates cagan_ree.md typos
add example admonition
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Jul 28, 2024
update typos
…re-python-intro into example_spelling
update typos
add example admonition
add example admonition
longye-tian
changed the title
Example and spelling
[ar1_processes] to [eigen_II.md] Example and spelling
Jul 28, 2024
Many thanks @longye-tian . This is very helpful. @mmcky , please review and merge when ready. |
- change 'from world population review' to 'from the World Population Review' - change 'Law of Large Numbers' to 'law of large numbers' to match with Wikipedia form as discussed before - change 'heavy tailed' to 'heavy-tailed' for consistency - change 'The value the tail index' to 'The value of the tail index' - change 'Here is code that generates' to 'Here is the code generates'
longye-tian
changed the title
[ar1_processes] to [eigen_II.md] Example and spelling
[ar1_processes] to [eigen_II] [heavy_tails]Example and spelling
Aug 1, 2024
- change 'per capital' to 'per capita' - change 'others is zero' to 'others are zero' - change 'the world bank' to 'the World Bank' to match Wikipedia - add empty link to match with the style guide - change 'Western economies GDP' to 'Western economies'GDP'
longye-tian
changed the title
[ar1_processes] to [eigen_II] [heavy_tails]Example and spelling
[ar1_processes] to [eigen_II] [heavy_tails][inequality]Example and spelling
Aug 1, 2024
- change 'input output' to 'input-output' for consistency - change **feasible allocations must satisfy** to *feasible allocations must satisfy* to match with style guide - change 'a two good economy' to 'a two-good economy'
This example admonition include code block
cannot include code blocks in the example admonition
mmcky
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @longye-tian this is great work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear John @jstac and Matt @mmcky ,
This pull request is to check the example admonition and spelling of from lecture [ar1_processes.md] to [eigen_II.md] according to #520 and #532.
The details are shown below:
Best ❤️
Longye