Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update to quantecon-book-theme==0.6.1 #295

Closed
wants to merge 1 commit into from
Closed

ENH: Update to quantecon-book-theme==0.6.1 #295

wants to merge 1 commit into from

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Oct 18, 2023

@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request October 18, 2023 03:07 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Oct 18, 2023

@AakashGfude thanks for this.

Is there a way to use an inverted quantecon logo for dark theme?

Also is there a lighter colour we can use for the right hand table of contents

Screenshot 2023-10-18 at 2 15 31 pm

also the title

Screenshot 2023-10-18 at 2 15 48 pm

Looking like a big improvement thought. Thanks.

cc: @HumphreyYang @HengchengZhang

@AakashGfude
Copy link
Member

Thanks @mmcky . Yes, I will add a lighter color. Since that image is jpg, so, if I invert the colour, the logo colour changes as well, for example:
Screen Shot 2023-10-18 at 2 33 22 pm

We can either try to create a new image for dark mode, or use this?

Thanks for the right hand toc, will add the same styling as left-hand toc:
Screen Shot 2023-10-18 at 2 32 56 pm

@mmcky
Copy link
Contributor Author

mmcky commented Oct 18, 2023

@DrDrij has a QuantEcon logo for dark backgrounds. I will try and dig it up. But it would be great if we can use a different logo to support dark mode.

@mmcky
Copy link
Contributor Author

mmcky commented Oct 19, 2023

@AakashGfude here is one for black backgrounds

qe-logo-on-black

@AakashGfude
Copy link
Member

Thanks @mmcky . I will get it done next week. When I am back to Canberra

@mmcky
Copy link
Contributor Author

mmcky commented Nov 1, 2023

closing as we will upgrade to 0.6.2 instead with improved dark theme support

@mmcky mmcky closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants