Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Update Numba Lecture to Address Deprecation of @jit #296

Merged
merged 7 commits into from
Dec 14, 2023
Merged

Conversation

HumphreyYang
Copy link
Collaborator

@HumphreyYang HumphreyYang commented Oct 24, 2023

This PR resolves #294.

Future actions are held in QuantEcon/meta#112

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

@github-actions github-actions bot temporarily deployed to pull request October 24, 2023 11:52 Inactive
@HumphreyYang
Copy link
Collaborator Author

Hi @mmcky,

Could you please have a first pass on this?

Many thanks in advance.

lectures/numba.md Outdated Show resolved Hide resolved
@mmcky
Copy link
Contributor

mmcky commented Oct 25, 2023

@HumphreyYang thanks for putting this together. This looks like a good change to me.

I wonder if using @jit(nopython=True) would be useful to show instead of @njit as we will plan to swap back to using the simpler @jit directive once the deprecation has been made in a later release.

Also can you please create and link the switch back to @jit issue.

Thank you.

@HumphreyYang
Copy link
Collaborator Author

@HumphreyYang thanks for putting this together. This looks like a good change to me.

I wonder if using @jit(nopython=True) would be useful to show instead of @njit as we will plan to swap back to using the simpler @jit directive once the deprecation has been made in a later release.

Also can you please create and link the switch back to @jit issue.

Thank you.

Hi @mmcky,

From the roadmap, I think Numba developers want to push people away from @jit(nopython=False). If that is the case, I think @njit is more compact. Maybe we should ask @jstac for his opinion?

Also can you please create and link the switch back to @jit issue.

It has been created in the meta repository here as it might involve more than one lecture.

Many thanks in advance.

Best,
Humphrey

@jstac
Copy link
Contributor

jstac commented Oct 26, 2023

Thanks @HumphreyYang and @mmcky . I'm indifferent between the two options, since we'll be changing both to @jit soon anyway.

@mmcky
Copy link
Contributor

mmcky commented Oct 26, 2023

thanks @HumphreyYang -- that linked issue is useful so I have added it to the top level description.

Do you know if njit is going to persist once the @jit decorator moves to default nopython=True mode?

@HumphreyYang
Copy link
Collaborator Author

thanks @HumphreyYang -- that linked issue is useful so I have added it to the top level description.

Do you know if njit is going to persist once the @jit decorator moves to default nopython=True mode?

Many thanks @mmcky,

I checked their documentation, but I did not find anything about the deprecation of njit. There is no deprecation warning when using njit at the moment. Therefore, I think it is not going to be removed.

lectures/numba.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HumphreyYang just one minor change. I am happy to keep njit for the sake of being concise.

@github-actions github-actions bot temporarily deployed to pull request November 1, 2023 11:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 20, 2023 05:06 Inactive
@HumphreyYang HumphreyYang requested review from mmcky and jstac November 22, 2023 02:23
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @HumphreyYang

@jstac there are some changes to content in this PR if you wanted to take a Quick Look.

@mmcky mmcky changed the title Update Numba Lecture to Address Deprecation of @jit FIX: Update Numba Lecture to Address Deprecation of @jit Dec 12, 2023
lectures/numba.md Outdated Show resolved Hide resolved
lectures/numba.md Outdated Show resolved Hide resolved
@jstac
Copy link
Contributor

jstac commented Dec 13, 2023

Thanks @HumphreyYang , looking good.

@mmcky Could you please give this a careful proofread and then merge when ready? I flagged a couple of small things above.

@github-actions github-actions bot temporarily deployed to pull request December 13, 2023 04:49 Inactive
@HumphreyYang
Copy link
Collaborator Author

HumphreyYang commented Dec 13, 2023

Many thanks @jstac and @mmcky ,

The typo is introduced when I modify the text according to @mmcky's feedback. I will be more careful when deleting content. I also found another typo in the original text : )

@mmcky, would you mind having another review and merge if it looks good?

Many thanks in advance.

@mmcky mmcky merged commit efe322b into main Dec 14, 2023
5 checks passed
@mmcky mmcky deleted the update-numba branch December 14, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation Warnings
3 participants