-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Update Numba Lecture to Address Deprecation of @jit
#296
Conversation
Hi @mmcky, Could you please have a first pass on this? Many thanks in advance. |
@HumphreyYang thanks for putting this together. This looks like a good change to me. I wonder if using Also can you please create and link the Thank you. |
Hi @mmcky, From the roadmap, I think Numba developers want to push people away from
It has been created in the Many thanks in advance. Best, |
Co-authored-by: mmcky <[email protected]>
Thanks @HumphreyYang and @mmcky . I'm indifferent between the two options, since we'll be changing both to @jit soon anyway. |
thanks @HumphreyYang -- that linked issue is useful so I have added it to the top level description. Do you know if |
Many thanks @mmcky, I checked their documentation, but I did not find anything about the deprecation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HumphreyYang just one minor change. I am happy to keep njit
for the sake of being concise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @HumphreyYang
@jstac there are some changes to content in this PR if you wanted to take a Quick Look.
@jit
@jit
Thanks @HumphreyYang , looking good. @mmcky Could you please give this a careful proofread and then merge when ready? I flagged a couple of small things above. |
Many thanks @jstac and @mmcky , The typo is introduced when I modify the text according to @mmcky's feedback. I will be more careful when deleting content. I also found another typo in the original text : ) @mmcky, would you mind having another review and merge if it looks good? Many thanks in advance. |
This PR resolves #294.
Future actions are held in QuantEcon/meta#112