-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: upgrade latest build software versions #326
Conversation
@DrDrij it looks like the variable names may have changed as we upgraded to any ideas? |
That's no good. Perhaps we hard code them temporarily? |
thanks @DrDrij just not sure how the templates actually get rendered. |
@DrDrij the interesting part is that the <p class="qe-page__header-authors" font-size="18">
<a href="http://www.tomsargent.com/" target="_blank"><span>Thomas J. Sargent</span></a>
and <a href="https://johnstachurski.net/" target="_blank"><span>John Stachurski</span></a>
</p> but it just isn't showing up on the rendered page |
however in the case of the The live site has <p class="logo">
<a href=https://quantecon.org><img src="_static/qe-logo.png" class="logo logo-img" alt="logo"></a>
<a href=https://quantecon.org><img src="_static/quantecon-logo-transparent.png" class="dark-logo-img" alt="logo"></a>
</p>
<p class="powered">Powered by <a href="https://jupyterbook.org/">Jupyter Book</a></p> while this preview build has
<p class="logo">
</p>
<p class="powered">Powered by <a href="https://jupyterbook.org/">Jupyter Book</a></p> |
Looks like authors is printed out in 2 places, the first instance shows on all other pages except 'main-index': And the second is appearing in the content area, after the Heading 1 element, so in the content block: (https://github.com/QuantEcon/quantecon-book-theme/blob/90fba30c2c4d7743333c9567bb8ac82b29871c36/src/quantecon_book_theme/theme/quantecon_book_theme/layout.html#L175C30-L175C39) So it means we've lost the author header printing out in the On further inspection, I see that the theme uses Javascript to move the authors on the homepage to sit in the right place under the Heading 1 (https://github.com/QuantEcon/quantecon-book-theme/blob/90fba30c2c4d7743333c9567bb8ac82b29871c36/src/quantecon_book_theme/assets/scripts/index.js#L380). How many years ago did I write this? 🙈 So JS is broken somewhere — try to open the left menu or use any of the theme toolbar buttons around the page. The console gives a little details which indicates we have lost jQuery. It appears that https://671b40f5a93d541ba1e37280--epic-agnesi-957267.netlify.app/_static/scripts/sphinx-book-theme.js isn't loading (404). Has that changed with the new version @mmcky ? Hope this gives some clue. I can investigate further, interested in your thoughts? |
@DrDrij @mmcky I'm having conversations in two places! I'll move the chat here. @DrDrij yes, Sphinx 6 dropped JQuery. The easiest fix is to bundle it with webpack by adding it to your dependencies, importing it in your JS file, and setting As for the SBT -- I wonder whether you really should only inherit from pydata-sphinx-theme, as that is where most/all of the accessibility etc features are. |
@DrDrij we will need to add in jQuery to get this to work for now. @agoose77 I agree that we should be inheriting from pydata-sphinx-theme. With our planned upcoming migration to |
This reverts commit d92de23.
@DrDrij @agoose77 thanks again for your help here. I have pinned quantecon-book-theme to use I have opened QuantEcon/quantecon-book-theme#274 to see if we can fix the jQuery issue and remove this pin. But happy with this solution for now given the upcoming switch to |
This reverts commit da5a2be.
@HumphreyYang this PR makes major upgrades to our I have done a pretty good review and check but if you have time to cast your eye over this preview to see if you spot any regressions that would be super helpful. https://674a6757a64b3c66ca69bb11--epic-agnesi-957267.netlify.app/ |
Many thanks @mmcky. I did not spot any issue! I think we did not use proof env in this repo so perhaps I can have another look in the undergraduate series once this change is implemented over there? |
thanks @HumphreyYang |
This upgrades the software to the latest versions of
jupyter-book
including updates toquantecon-book-theme
andsphinx-exercise
for compatibility.quantecon-book-theme==0.7.5
once bugs fixedsphinx-exercise==1.0.1
once bugs fixedjupyter-book==1.0.3