-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👌 IMPROVE: RHS TOC sticky when scrolling option #144
Open
DrDrij
wants to merge
38
commits into
main
Choose a base branch
from
rhs-toc-adjustments
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 23 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
499b061
Add condition for sticky toc
DrDrij 7923265
Merge branch 'master' into rhs-toc-adjustments
AakashGfude 2e6acdd
Add link highlighting function for page TOC
DrDrij 0fe9120
Add styles for page TOC highlighting
DrDrij 6f9d006
Page TOC style tweak
DrDrij 0b98935
Hide nested pages in page TOC
DrDrij 17ccb9e
Add sticky_toc option to conf
DrDrij 85ed2f2
Only highlight if sticky
DrDrij 341ee62
Add context to RHS TOC parameter
DrDrij d5e85ab
Add context to RHS TOC parameter
DrDrij 8fe2483
Add context to RHS TOC parameter
DrDrij 7f004f0
Add context to RHS TOC parameter
DrDrij cb28e45
merging master
AakashGfude 1bd3d58
editing pre-commit config
AakashGfude 43030f4
theme.conf
AakashGfude aa6f864
setup.py
AakashGfude 67bf824
versions in pre-commit
AakashGfude 23777b6
ensuring markupsafe is right version
AakashGfude db6cdca
minor setup fix
AakashGfude ba7f601
markupsafe
AakashGfude f22348c
checkout branch of lecture-python-programming.myst with rhs toc settings
mmcky adde74b
checkout correct branch after cloning
mmcky c932aa7
checkout inside repo
mmcky 42da195
sticky_toc
AakashGfude 3ec412e
sphinx version
AakashGfude 20c8790
changing install order
AakashGfude 91f2ec9
fixing sphinx versions
AakashGfude d00b16f
Merge branch 'master' into rhs-toc-adjustments
AakashGfude eb7e422
Merge branch 'master' into rhs-toc-adjustments
AakashGfude b50aed5
changing to sticky_contents
AakashGfude be53f5c
input checkbox styling
AakashGfude 05cd737
updating master
AakashGfude 0acf72c
keeping it True by deafult
AakashGfude 9abf43c
resolved merge conflict
AakashGfude 8416d73
sticky_contents default reverted
AakashGfude 6f47f6a
Merge branch 'master' into rhs-toc-adjustments
AakashGfude 06127b2
running pre-commit
AakashGfude a75930f
update to python=3.10
mmcky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
quantecon_book_theme/static/quantecon-book-theme.1ef59f8f4e91ec8319176e8479c6af4e.css
This file was deleted.
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
...theme.15b0c36fffe88f468997fa7b698991d3.js → ...theme.3caa2f986129bf7e5acaef47c8987a7b.js
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
quantecon_book_theme/static/quantecon-book-theme.8e803950472302ed98c42444678c3bbd.css
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,3 +27,5 @@ keywords = | |
twitter = | ||
twitter_logo_url = | ||
og_logo_url = | ||
sticky_toc = False | ||
persistent_sidebar = False |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AakashGfude is the option called
theme_sticky_contents
orsticky_contents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theme_
is appended by sphinx itself forhtml_theme_options
. Unfortunately, it's neither 😬. The correct one istheme_sticky_toc
. I have corrected it.