-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support scheme 'file' to process local conda files #71
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Could you please add an integration test for this feature? You can add a new example for this.
|
||
// Ensure target directory exists | ||
let target_path = output_dir.join(file_name); | ||
create_dir_all(target_path.parent().unwrap_or_else(|| Path::new("."))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fishy. Why do we need it and why using the current working directory as default? Shouldn't we rather fail in these cases?
I ran integration tests but only 3 tests passed( |
in https://github.com/Quantco/pixi-pack/blob/19c4b336f37c8c11de467ce058cf846de589d536/tests/integration_test.rs you can find some integration tests, just adding another one that covers your use case should be fine |
Alright, I will add a new integration test and rethink the implementation of |
I encountered a problem: |
@amamiya-len i pushed an integration test that just templates the pixi.toml |
OK,I see. I was a little busy days ago. |
Motivation
In my situations, I made some private packages locally and add dependencies with 'file' URLs in
pixi.toml
(actuallypixi
support 'file' URLs), but it seems that pixi-pack doesn't support 'file' URLs. So I add support for scheme 'file'.Changes
Just changed function
download_package
.