add support for polars 1 #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 2 2
Lines 211 211
=======================================
Hits 207 207
Misses 4 4 ☔ View full report in Codecov by Sentry. |
0xbe7a
reviewed
Jul 7, 2024
| @@ -9,7 +9,7 @@ platforms = ["linux-64", "osx-arm64", "osx-64", "win-64"] | |||
|
|
|||
| [dependencies] | |||
| python = ">=3.9" | |||
| polars = ">=0.14.24,<0.21" | |||
| polars = ">=0.14.24,<2" | |||
There was a problem hiding this comment.
I think we should pin to <1.1
There was a problem hiding this comment.
shouldn't the next breaking change be polars 2? since we are not touching polars internals but only the public api, this should be fine imo. but if you have strong opinions on this, we can also pin to <1.1
There was a problem hiding this comment.
They might add unsupported syntax without bumping the major version. Let's keep a rather tight pin to 1.1 or 1.2 here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.