Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macos & add to CI #118

Merged
merged 16 commits into from
Nov 23, 2023
Merged

Fix macos & add to CI #118

merged 16 commits into from
Nov 23, 2023

Conversation

SimeonStoykovQC
Copy link
Member

@SimeonStoykovQC SimeonStoykovQC commented Nov 21, 2023 •
edited
Loading

Small test fixes to make it run on macos.

Checklist

  • Added a CHANGELOG.rst entry - only tests/CI change

@SimeonStoykovQC SimeonStoykovQC changed the base branch from main to onnx-rc1 November 22, 2023 05:25
xhochy
xhochy reviewed Nov 22, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@SimeonStoykovQC
Copy link
Member Author

The opset generation produced different results to what's in main, so I had to rebase on #115 - or is there a better approach?

@SimeonStoykovQC SimeonStoykovQC marked this pull request as ready for review November 22, 2023 16:54
Base automatically changed from onnx-rc1 to main November 22, 2023 17:50
cbourjau
cbourjau approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@cbourjau cbourjau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good to go if the CI passes after applying those suggestions.

tests/type_inference/test_compress.py Outdated Show resolved Hide resolved
tests/type_inference/test_compress.py Outdated Show resolved Hide resolved
tests/type_inference/test_compress.py Outdated Show resolved Hide resolved
@cbourjau cbourjau merged commit bee7d65 into main Nov 23, 2023
10 checks passed
@cbourjau cbourjau deleted the osx-fix-ci branch November 23, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy left review comments

@cbourjau cbourjau cbourjau approved these changes

@adityagoel4512 adityagoel4512 Awaiting requested review from adityagoel4512 adityagoel4512 is a code owner

@jbachurski jbachurski Awaiting requested review from jbachurski jbachurski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimeonStoykovQC @xhochy @cbourjau @adityagoel4512