Added decoding pipeline file #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The evaluate_decoder method should be the only public facing method as the rest should only need to be called by evaluate_classical_decoder. I have created 2 versions of evaluate_classical_decoder. One of them should work, and it takes in a decoder object. The type of the object detemines which decoder is called later on in the function. The decoding is done with a Pauli frame simulation based upon code written by Anthony for evaluating the belief propagation decoder. I have tried to test my methods, but I've been having a problem with running standard Stabilizer type methods on Stabilizer objects that I created from a Hx and Hz matrix. Pointers on how to fix this would be appreciated! I have included a CSS class below which includes some methods I use in the decoder.
Krastanov
reviewed
Dec 19, 2023
There was a problem hiding this comment.
- it is difficult to decide how to take care of interdependencies between LDPCDecoders and QuantumClifford. For the moment let's use the following structure:
- QuantumClifford will start depending on LDPCDecoders
- LDPCDecoders thus can not contain anything imported from QuantumClifford
- LDPCDecoders should contain the API for classical decoders. Currently, that does not really exist, only an API for quantum decoders is implemented in this PR.
- Let's move the quantum decoders API to QuantumClifford
- No need to worry about creating a classical decoder API yet, it probably is not a good use of your limited time
- If one day there is a classical decoder API in this package, the quantum decoder API in QuantumClifford should depend on the classical one, not the other way around
|
Addressed the above comments and moved the code to QuantumClifford.jl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The evaluate_decoder method should be the only public facing method as the rest should only need to be called by evaluate_classical_decoder.
Created 2 versions of evaluate_classical_decoder. One of them should work, and it takes in a decoder object. The type of the object detemines which decoder is called later on in the function. The decoding is done with a Pauli frame simulation based upon code written by Anthony for evaluating the belief propagation decoder.
Tried to test my methods, but I've been having a problem with running standard Stabilizer type methods on Stabilizer objects that I created from a Hx and Hz matrix. Pointers on how to fix this would be appreciated!
Included a CSS class below which includes some methods I use in the decoder, specifically the parity_checks method. In the future this will be added to QuantumClifford.