Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]Add vm.icon property #138

Closed
wants to merge 2 commits into from
Closed

[WIP]Add vm.icon property #138

wants to merge 2 commits into from

Conversation

marmarta
Copy link
Member

This is a property for handling vm icons that change depending on
vm type.
Depends on QubesOS/qubes-artwork#17

references QubesOS/qubes-issues#5767

@marmarta
Add vm.icon property
6635efe 
This is a property for handling vm icons that change depending on
vm type.
Depends on QubesOS/qubes-artwork#17

references QubesOS/qubes-issues#5767
marmarek
marmarek requested changes Apr 30, 2020
View reviewed changes
Copy link
Member

@marmarek marmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please define new properties in core-admin repo, not here (use @qubes.stateless_property decorator there to have it exposed via Admin API). core-admin-client is supposed to be just a wrapper around Admin API, not carry any logic.

@marmarta marmarta closed this May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marmarek marmarek marmarek requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marmarta @marmarek