Update to qt6 #387
Open
Update to qt6 #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmarta
force-pushed
the
update_to_qt6
branch
11 times, most recently
from
f297823
to
9867550
Compare
marmarta
force-pushed
the
update_to_qt6
branch
3 times, most recently
from
6020848
to
357c529
Compare
|
@marmarek , could I get this tested in openqa? There are multiple ways this could go wrong, I'd like to see how it looks on a non-frankenstein system. |
|
Sure |
marmarta
force-pushed
the
update_to_qt6
branch
from
357c529
to
e447809
Compare
|
openqa worked, in that it found an instant death bug. Asking for another round. |
This was referenced Oct 17, 2024
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024101520-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024070519-4.3&flavor=update
Failed tests73 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/105374#dependencies 8 fixed
Unstable tests
|
This was referenced Oct 17, 2024
This was referenced Oct 17, 2024
marmarta
force-pushed
the
update_to_qt6
branch
2 times, most recently
from
e7ced11
to
f5af28f
Compare
Changed Template Manager UI to be more friendly. Added a lot of explanations. Functionally, added checking for obsolete templates.
Updated all files to Qt version 6. Based on the template manager redesign. fixes QubesOS/qubes-issues#9476
marmarta
force-pushed
the
update_to_qt6
branch
from
f5af28f
to
a8ec317
Compare
And also to improve code readability.
Removed CI build for Ubuntu Jammy, because it does not contain necessary pyqt6 packages; newer versions do contain it.
marmarta
force-pushed
the
update_to_qt6
branch
from
a8ec317
to
56c76a6
Compare
|
Ready for re-review and tests, @marmarek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all programs to use Qt6. May or may not cause weird palette bugs in dom0 (local testing inconclusive); please test.
Based on #382
Does not involve any actual changes in functionality (hopefully).
fixes QubesOS/qubes-issues#9476