Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Create new qube ComboBoxes smart #389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alimirjamali
Copy link
Contributor

Select (None) for Template and Networking if user selects TemplateVM for Type in Create new qube dialog.

related: QubesOS/qubes-issues#9174

Select (None) for `Template` and `Networking` if user selects
`TemplateVM` for `Type` in Create new qube dialog.

related: QubesOS/qubes-issues#9174
@alimirjamali
Copy link
Contributor Author

Pylint has failed due to Gitlab error 500

@marmarek
Copy link
Member

marmarek commented Oct 5, 2024

PipelineRetryFailed

@marmarek
Copy link
Member

marmarek commented Oct 5, 2024

@alimirjamali you've got powers to issue those commands too; see https://www.qubes-os.org/doc/continuous-integration/#website-and-documentation for the list (all except TestDeploy work on any PR, not just doc)

@alimirjamali
Copy link
Contributor Author

alimirjamali commented Oct 5, 2024

@alimirjamali you've got powers to issue those commands too; see https://www.qubes-os.org/doc/continuous-integration/#website-and-documentation for the list (all except TestDeploy work on any PR, not just doc)

Thank you very much for the information.

The pylint test still fails and Gitlab shows error 500. Is the server really broken or am I missing anything here? The same test fails for this which is only minor changes to a Glade file.

@marmarek
Copy link
Member

marmarek commented Oct 5, 2024

Viewing any gitlab job logs give me 500. Maybe related to issue described at https://status.gitlab.com/? It doesn't look related, but maybe?

@marmarek
Copy link
Member

marmarek commented Oct 5, 2024

If I login to gitlab, then it works.

************* Module qubesmanager.bootfromdevice
qubesmanager/bootfromdevice.py:32:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
************* Module qubesmanager.create_new_vm
qubesmanager/create_new_vm.py:42:4: R0917: Too many positional arguments (8/5) (too-many-positional-arguments)
************* Module qubesmanager.device_list
qubesmanager/device_list.py:25:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
************* Module qubesmanager.settings
qubesmanager/settings.py:141:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
************* Module qubesmanager.template_manager
qubesmanager/template_manager.py:320:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
************* Module qubesmanager.utils
qubesmanager/utils.py:200:0: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
qubesmanager/utils.py:250:0: R0917: Too many positional arguments (8/5) (too-many-positional-arguments)
qubesmanager/utils.py:294:0: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
qubesmanager/utils.py:354:0: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)

(not related to your changes, just pylint update...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants