Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on edk2-ovmf-xen instead of bundling OVMF #195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DemiMarie
Copy link
Contributor

This fixes two bugs:

  1. The bundled OVMF didn't support Xen, so UEFI guests failed to boot.
  2. The bundled OVMF didn't include the license text alongside it.

Fixes: QubesOS/qubes-issues#8625

This fixes two bugs:

1. The bundled OVMF didn't support Xen, so UEFI guests failed to boot.
2. The bundled OVMF didn't include the license text alongside it.

Fixes: QubesOS/qubes-issues#8625
@marmarek
Copy link
Member

Looks good, but I'd like to make a test for that first. If you want to help, take a look at simple VM startup tests in core-admin, and add one that checks if UEFI VM boots too (and test if this PR really fixes it).

@DemiMarie
Copy link
Contributor Author

When I tested (an equivalent to) this myself, it was enough to get the firmware loading, but I was dumped into a UEFI shell because /boot/efi could not be mounted in the firmware. I would prefer to merge this change first, and then fix the problems inside the guest that prevent booting past the UEFI shell.

@marmarek
Copy link
Member

I'm going to insist on a test in core-admin, but if you don't want to, I can add it too. It doesn't need to test full qubes-template-based qube booting with UEFI. In fact, I believe that's very minor use case for this feature. It can be something minimal - maybe even just grub configured to print something to the console? (see the cdrom boot test, that one uses syslinux, but you get the idea).
This would for example show that this PR itself results in a VM that still fails to boot at all in R4.3 (with updated libvirt).

@DemiMarie
Copy link
Contributor Author

I’ll add the test. I just thought you wanted me to test that a standard Qubes VM booted with UEFI firmware (which it doesn’t).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UEFI enabled HVMs hang on "Guest has not initialized the display (yet)"
2 participants