Addition of immunization history class #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f object in person constructor.
mark-r-anderson
requested changes
Mar 28, 2023
| @@ -386,65 +420,15 @@ def get_student_pop_size(self): | |||
| """ | |||
| return self.nStudents | |||
|
|
|||
| def add_visitors(self, day): | |||
There was a problem hiding this comment.
FYI, this still seems to have the problem of accidentally reverting changes made in #201. To clean up the commit history and properly fix this, you'll likely need to revert most of the merge commits made (from a quick glance, perhaps go back to commit d149712), test the code to make sure it runs (you may want to implement the changes from 894165a before the next step), make one single merge commit to bring everything up to date with the main branch (there will be merge conflicts, but Noah and I can help with that), and then finally fix any remaining problems from the automated tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of PR #193 from the previous repository. This pull request intends to incorporate time-dependent vaccine efficacy to the simulation by adding a new class that keeps track of vaccine-related information.