Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add submit request functionality #49

Merged
merged 22 commits into from
Jan 3, 2024
Merged

Feat/add submit request functionality #49

merged 22 commits into from
Jan 3, 2024

Conversation

barrydilan
Copy link
Collaborator

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

Related Tickets & Documents

Screenshots, Recordings

Please replace this line with any relevant images for UI changes.
Π‘Π½ΠΈΠΌΠΎΠΊ экрана 2023-12-30 Π² 13 53 59

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@barrydilan barrydilan requested review from Quiddlee and Tedzury and removed request for Tedzury and Quiddlee December 30, 2023 12:55
Quiddlee
Quiddlee requested changes Dec 31, 2023
View reviewed changes
src/components/RequestEditor/RequestEditor.tsx Outdated Show resolved Hide resolved
src/components/RequestEditor/lib/const/const.ts Outdated Show resolved Hide resolved
src/components/RequestEditor/lib/const/const.ts Outdated Show resolved Hide resolved
src/components/RequestEditor/lib/formatRequest.ts Outdated Show resolved Hide resolved
src/components/RequestEditor/ui/Controls.tsx Show resolved Hide resolved
src/components/ResponseViewer/ResponseViewer.tsx Outdated Show resolved Hide resolved
src/components/Editor/lib/submitRequest.ts Show resolved Hide resolved
src/components/Editor/ui/EditorField.tsx Outdated Show resolved Hide resolved
@barrydilan barrydilan requested a review from Quiddlee December 31, 2023 12:04
@Quiddlee Quiddlee self-requested a review December 31, 2023 16:55
Tedzury
Tedzury approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@Tedzury Tedzury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Great work!

@Quiddlee Quiddlee merged commit 7a90c9a into develop Jan 3, 2024
3 checks passed
@Quiddlee Quiddlee deleted the feat/add_submit_request_functionality branch January 3, 2024 10:32
@Quiddlee Quiddlee restored the feat/add_submit_request_functionality branch January 7, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quiddlee Quiddlee Quiddlee approved these changes

@Tedzury Tedzury Tedzury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add submit response functionality
3 participants
@barrydilan @Tedzury @Quiddlee