Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a section about quilt config #81

Merged
merged 18 commits into from
Feb 27, 2024
Merged

add a section about quilt config #81

merged 18 commits into from
Feb 27, 2024

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Jan 29, 2024

page completion:

  • getting started
  • advanced configuring
  • metadata and annotations

See preview on Cloudflare Pages: https://preview-81.developer-wiki.pages.dev

@ix0rai ix0rai added content Relates to the content of the wiki new page adds a new wiki page labels Jan 29, 2024
Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start

wiki/configuration/advanced-configuring/en.md Show resolved Hide resolved
wiki/configuration/advanced-configuring/en.md Show resolved Hide resolved
wiki/configuration/getting-started/en.md Outdated Show resolved Hide resolved
wiki/configuration/getting-started/en.md Show resolved Hide resolved
wiki/configuration/getting-started/en.md Show resolved Hide resolved
wiki/configuration/getting-started/en.md Show resolved Hide resolved
wiki/configuration/getting-started/en.md Outdated Show resolved Hide resolved
Copy link
Contributor

@anonymous123-code anonymous123-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a little inconsistency in that knowledge is expected: It is explained that you need an instance in order to access a non static field, as well as a grasp on generics from a few sentences.

Additionally, you might want to mention that quilt config provides so much metadata stuff so that automatic config screens can also be implemented

wiki/configuration/getting-started/en.md Outdated Show resolved Hide resolved
wiki/configuration/getting-started/en.md Outdated Show resolved Hide resolved
wiki/configuration/getting-started/en.md Outdated Show resolved Hide resolved
@ix0rai
Copy link
Member Author

ix0rai commented Feb 5, 2024

There is a little inconsistency in that knowledge is expected: It is explained that you need an instance in order to access a non static field, as well as a grasp on generics from a few sentences.

Additionally, you might want to mention that quilt config provides so much metadata stuff so that automatic config screens can also be implemented

I'm thinking of axing the manual config screen article in favor of just devoting the time I would have spent to working on your project :p

@ix0rai
Copy link
Member Author

ix0rai commented Feb 6, 2024

not sure if I mentioned it. these tutorials are being written as if Qconf 1.3 has already been released and integrated into loader

Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it looks good so i cant keep having you go back and fix minor issues

@ix0rai
Copy link
Member Author

ix0rai commented Feb 6, 2024

don't worry oro I have like 3 more to write

wiki/configuration/advanced-configuring/en.md Outdated Show resolved Hide resolved
wiki/configuration/advanced-configuring/en.md Show resolved Hide resolved
@ix0rai
Copy link
Member Author

ix0rai commented Feb 15, 2024

all comments are resolved!

Copy link
Contributor

@supersaiyansubtlety supersaiyansubtlety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little things

wiki/configuration/advanced-configuring/en.md Outdated Show resolved Hide resolved
wiki/configuration/advanced-configuring/en.md Outdated Show resolved Hide resolved
wiki/configuration/advanced-configuring/en.md Outdated Show resolved Hide resolved
wiki/configuration/advanced-configuring/en.md Outdated Show resolved Hide resolved
wiki/configuration/advanced-configuring/en.md Outdated Show resolved Hide resolved
wiki/configuration/advanced-configuring/en.md Show resolved Hide resolved
@ix0rai ix0rai marked this pull request as ready for review February 18, 2024 05:16
wiki/configuration/config-screen/en.md Show resolved Hide resolved
wiki/configuration/metadata/en.md Outdated Show resolved Hide resolved
@ix0rai ix0rai merged commit b328b22 into QuiltMC:main Feb 27, 2024
1 check passed
@ix0rai ix0rai deleted the config branch February 27, 2024 03:30
@ix0rai ix0rai mentioned this pull request Mar 3, 2024
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Relates to the content of the wiki final comment period new page adds a new wiki page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants