Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding custom worldtypes round 2 #84

Merged
merged 46 commits into from
May 4, 2024
Merged

adding custom worldtypes round 2 #84

merged 46 commits into from
May 4, 2024

Conversation

woodiertexas
Copy link
Contributor

@woodiertexas woodiertexas commented Feb 7, 2024

a continuation of #79 that was using a dated "rewrite" branch of my months old wiki fork and since it caused me issues, i wanted to refork and try again


See preview on Cloudflare Pages: https://preview-84.developer-wiki.pages.dev

Copy link
Contributor

@anonymous123-code anonymous123-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all the formatting nitpicks

Also maybe switch to giving the code first and explaining it afterwards. Right now you reference stuff without any context where it should be until the end of the explanantion

wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
Copy link
Contributor

@anonymous123-code anonymous123-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know much about word gen, but it might be good to also add a page that explains what all the different types mean. (world preset, dimension type, generator, biome sources, etc.) It might also mean that this article only works well within the context of a full worldgen wiki.

wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
Co-authored-by: anonymous123-code <[email protected]>
@ix0rai
Copy link
Member

ix0rai commented Mar 3, 2024

uses the terms "world preset" and "worldtype" without explaining the difference between the two

this can be fixed by having a "dictionary" portion of a page

or just explain in the intro

@woodiertexas
Copy link
Contributor Author

uses the terms "world preset" and "worldtype" without explaining the difference between the two

this can be fixed by having a "dictionary" portion of a page

or just explain in the intro

right here?
image

@ix0rai
Copy link
Member

ix0rai commented Mar 3, 2024

yes

@woodiertexas
Copy link
Contributor Author

shaping up! still has 2 major issues

* the "here are the valid things: [lists literally just one item]" issue

* uses the terms "world preset" and "worldtype" without explaining the difference between the two

also,

Now, what is a custom worldtype you may ask? World types define world generation options for Minecraft worlds. They let you change the make-up of your Minecraft worlds by configuring how world generation behaves.

how did you gloss over this?

@ix0rai
Copy link
Member

ix0rai commented Mar 3, 2024

shaping up! still has 2 major issues

* the "here are the valid things: [lists literally just one item]" issue

* uses the terms "world preset" and "worldtype" without explaining the difference between the two

also,

Now, what is a custom worldtype you may ask? World types define world generation options for Minecraft worlds. They let you change the make-up of your Minecraft worlds by configuring how world generation behaves.

how did you gloss over this?

this is explaining world types. you never explain the term world preset or contrast the two

@woodiertexas
Copy link
Contributor Author

shaping up! still has 2 major issues

* the "here are the valid things: [lists literally just one item]" issue

* uses the terms "world preset" and "worldtype" without explaining the difference between the two

also,

Now, what is a custom worldtype you may ask? World types define world generation options for Minecraft worlds. They let you change the make-up of your Minecraft worlds by configuring how world generation behaves.

how did you gloss over this?

this is explaining world types. you never explain the term world preset or contrast the two

someone skipped my latest commit: 553b8cd

Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noise is still the only one of the valid generator IDs, and I'd like to see a little more consistency in type vs preset (pick a favourite, use it the whole article. I'd prefer to see world type as the favourite). otherwise after a style pass this looks good!

wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
@woodiertexas woodiertexas requested a review from ix0rai March 4, 2024 08:17
wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
Co-authored-by: ix0rai <[email protected]>
Copy link
Contributor

@anonymous123-code anonymous123-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of formatting and formulation improvements. The content and structure are looking good.

wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
woodiertexas and others added 5 commits March 10, 2024 04:32
Co-authored-by: anonymous123-code <[email protected]>
Co-authored-by: anonymous123-code <[email protected]>
Co-authored-by: anonymous123-code <[email protected]>
Co-authored-by: anonymous123-code <[email protected]>
Co-authored-by: anonymous123-code <[email protected]>
wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
```
This will generate a world relatively similar to that of MC's default overworld generation.

## Making your worldtype accessible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section could use a note about how to select custom world types on a dedicated server (server.properties)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this fixed? i dont see any reference to this

wiki/misc/world_types/en.md Outdated Show resolved Hide resolved
@ix0rai ix0rai merged commit b50375b into QuiltMC:main May 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Relates to the content of the wiki new page adds a new wiki page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants