-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding custom worldtypes round 2 #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for all the formatting nitpicks
Also maybe switch to giving the code first and explaining it afterwards. Right now you reference stuff without any context where it should be until the end of the explanantion
Co-authored-by: anonymous123-code <[email protected]>
Co-authored-by: anonymous123-code <[email protected]>
Co-authored-by: anonymous123-code <[email protected]>
Co-authored-by: anonymous123-code <[email protected]>
Co-authored-by: anonymous123-code <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know much about word gen, but it might be good to also add a page that explains what all the different types mean. (world preset, dimension type, generator, biome sources, etc.) It might also mean that this article only works well within the context of a full worldgen wiki.
Co-authored-by: anonymous123-code <[email protected]>
or just explain in the intro |
yes |
also,
how did you gloss over this? |
this is explaining world types. you never explain the term world preset or contrast the two |
someone skipped my latest commit: 553b8cd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noise
is still the only one of the valid generator IDs, and I'd like to see a little more consistency in type vs preset (pick a favourite, use it the whole article. I'd prefer to see world type as the favourite). otherwise after a style pass this looks good!
Co-authored-by: ix0rai <[email protected]>
Co-authored-by: ix0rai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of formatting and formulation improvements. The content and structure are looking good.
Co-authored-by: anonymous123-code <[email protected]>
Co-authored-by: anonymous123-code <[email protected]>
Co-authored-by: anonymous123-code <[email protected]>
Co-authored-by: anonymous123-code <[email protected]>
Co-authored-by: anonymous123-code <[email protected]>
``` | ||
This will generate a world relatively similar to that of MC's default overworld generation. | ||
|
||
## Making your worldtype accessible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section could use a note about how to select custom world types on a dedicated server (server.properties
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this fixed? i dont see any reference to this
Co-authored-by: Eli Orona <[email protected]>
a continuation of #79 that was using a dated "rewrite" branch of my months old wiki fork and since it caused me issues, i wanted to refork and try again
See preview on Cloudflare Pages: https://preview-84.developer-wiki.pages.dev