Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mostly client mappings #469

Merged
merged 5 commits into from
Aug 3, 2023
Merged

mostly client mappings #469

merged 5 commits into from
Aug 3, 2023

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Jul 27, 2023

new mappings? in this economy?

discussion question: should we consider breaking up the "every block is in net.minecraft.block" convention for absolutely wild stuff like putting sign blocks in net.minecraft.block.sign?

@ix0rai ix0rai added t: new adds new mappings v: release targets a release version of minecraft reviews needed please review this PR s: medium PRs with less than 700 lines and more than 200 labels Jul 27, 2023
supersaiyansubtlety
supersaiyansubtlety reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@supersaiyansubtlety supersaiyansubtlety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussion question: should we consider breaking up the "every block is in net.minecraft.block" convention for absolutely wild stuff like putting sign blocks in net.minecraft.block.sign?

Sounds good to me.

mappings/net/minecraft/client/multiplayer/prediction/BlockStatePredictionManager.mapping Show resolved Hide resolved
mappings/net/minecraft/client/util/telemetry/event/GameLoadTimesEvent.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/util/SegmentedAnglePrecision.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/util/SegmentedAnglePrecision.mapping Outdated Show resolved Hide resolved
@ix0rai
Copy link
Member Author

ix0rai commented Jul 28, 2023

discussion question: should we consider breaking up the "every block is in net.minecraft.block" convention for absolutely wild stuff like putting sign blocks in net.minecraft.block.sign?

Sounds good to me.

this is now implemented!

EnnuiL
EnnuiL suggested changes Jul 29, 2023
View reviewed changes
Copy link
Contributor

@EnnuiL EnnuiL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait oh right; Javadoc's mad at you for missing references; should be an easy fix :p

@supersaiyansubtlety supersaiyansubtlety mentioned this pull request Jul 29, 2023
Closed
@ix0rai ix0rai requested a review from EnnuiL August 1, 2023 01:30
@ix0rai ix0rai added final-comment-period is approved and will soon be merged if no issues are raised and removed reviews needed please review this PR labels Aug 2, 2023
@ix0rai ix0rai mentioned this pull request Aug 2, 2023
Merged
@ix0rai ix0rai merged commit fe7e29d into QuiltMC:1.20.1 Aug 3, 2023
4 checks passed
@ix0rai ix0rai deleted the mapping branch August 3, 2023 02:33
@EnnuiL EnnuiL mentioned this pull request Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EnnuiL EnnuiL EnnuiL approved these changes

@supersaiyansubtlety supersaiyansubtlety supersaiyansubtlety approved these changes

Assignees
No one assigned
Labels
final-comment-period is approved and will soon be merged if no issues are raised s: medium PRs with less than 700 lines and more than 200 t: new adds new mappings v: release targets a release version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ix0rai @supersaiyansubtlety @EnnuiL