Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

100% coverage of net.minecraft.data #515

Merged
merged 12 commits into from
Nov 17, 2023
Merged

100% coverage of net.minecraft.data #515

merged 12 commits into from
Nov 17, 2023

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Nov 6, 2023 •
edited
Loading

  • coverage. mostly mojanged instead of yarned, unless it goes against existing names
  • bumps plugin to 1.4 (should make a devlog about this!)
  • all refactors are for mappings that are fully wrong at this point
  • uses names from Advancements #496 as a base
  • hardens spellcheck against errors when a package name has duplicate words

@ix0rai ix0rai added t: new adds new mappings v: snapshot targets a snapshot version of minecraft reviews needed please review this PR s: large PRs with more than 700 lines labels Nov 6, 2023
supersaiyansubtlety
supersaiyansubtlety reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@supersaiyansubtlety supersaiyansubtlety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple questions

mappings/net/minecraft/data/server/tag/TagsProvider.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/recipe/RecipeCodecThingTODO.mapping Outdated Show resolved Hide resolved
@ix0rai ix0rai added final-comment-period is approved and will soon be merged if no issues are raised reviews needed please review this PR and removed reviews needed please review this PR final-comment-period is approved and will soon be merged if no issues are raised labels Nov 12, 2023
@OroArmor OroArmor added final-comment-period is approved and will soon be merged if no issues are raised and removed reviews needed please review this PR labels Nov 12, 2023
@ix0rai
Merge branch '23w44a' into 1.20.3/data
d1c07d5 
# Conflicts:
#	mappings/net/minecraft/advancement/criterion/CriterionTrigger.mapping
#	mappings/net/minecraft/data/server/advancement/AdventureAdvancementTabGenerator.mapping
@ix0rai ix0rai merged commit b553e5a into QuiltMC:23w44a Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OroArmor OroArmor OroArmor approved these changes

@supersaiyansubtlety supersaiyansubtlety supersaiyansubtlety approved these changes

Assignees
No one assigned
Labels
final-comment-period is approved and will soon be merged if no issues are raised s: large PRs with more than 700 lines t: new adds new mappings v: snapshot targets a snapshot version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ix0rai @supersaiyansubtlety @OroArmor