-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
World Renderer and Friends Mappings #628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OroArmor
added
t: new
adds new mappings
v: snapshot
targets a snapshot version of minecraft
wip
this is a work in progress
t: javadoc
this pull request updates or adds new javadoc
reviews needed
please review this PR
s: medium
PRs with less than 700 lines and more than 200
labels
Aug 16, 2024
ix0rai
reviewed
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clound is top 10 typos imo
supersaiyansubtlety
requested changes
Aug 17, 2024
OroArmor
added
s: large
PRs with more than 700 lines
and removed
s: medium
PRs with less than 700 lines and more than 200
labels
Aug 19, 2024
supersaiyansubtlety
approved these changes
Aug 19, 2024
ix0rai
reviewed
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few convention nitpicks
Co-authored-by: ix0rai <[email protected]>
ix0rai
approved these changes
Aug 20, 2024
ix0rai
added
final-comment-period
is approved and will soon be merged if no issues are raised
and removed
reviews needed
please review this PR
labels
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
final-comment-period
is approved and will soon be merged if no issues are raised
s: large
PRs with more than 700 lines
t: javadoc
this pull request updates or adds new javadoc
t: new
adds new mappings
v: snapshot
targets a snapshot version of minecraft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a lot of new mappings and refactors