-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix+clarify ChunkTickScheduler, complete n.m.world.tick #640
fix+clarify ChunkTickScheduler, complete n.m.world.tick #640
Conversation
🚀 Target branch has been updated to 24w38a |
You should take a look at the new world interface that exists now |
that does look tick-y |
probably. |
move TickPriority to tick package complete n.m.world.tick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, great refactors!
🚀 Target branch has been updated to 24w39a |
🚀 Target branch has been updated to 24w40a |
When adding a block tick scheduler to one of my mods I was dismayed to find
ChunkTickScheduler
had three fields that seemed very similar:I was also surprised that
void disable(long time)
was the method responsible for making sure deserialized ticks actually get scheduled.I've renamed them:
I also added some javadocs clarifying how
initialTicks
works and renamed things to more consistently use "schedule".Now also completes
n.m.world.tick