Improve mixin quality for Status Effect API #383
+86
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OroArmor
added
bug
ix0rai
approved these changes
Sep 8, 2024
...ntity/status_effect/src/main/java/org/quiltmc/qsl/entity/effect/mixin/LivingEntityMixin.java
Outdated
Show resolved
Hide resolved
…ity/effect/mixin/LivingEntityMixin.java Co-authored-by: ix0rai <[email protected]>
TheGlitch76
reviewed
Sep 20, 2024
| @Mixin(LivingEntity.class) | ||
| // We want to make sure that our wrap operations are put before other mods, so that we wrap the vanilla call and not a mod's call. | ||
| // This is because we do not call the vanilla method, so any mod adding something will not be called. | ||
| @Mixin(value = LivingEntity.class, priority = 500) |
There was a problem hiding this comment.
it would probably be wise to set the default priority to around this number globally
TheGlitch76
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few crashes with this code. Should be fairly easy to backport to older versions if need be. I think some of the changes with
StatusEffect->Holder<StatusEffect>would need to be reverted.