Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search packet and entity change action extra data #290

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

DrexHD
Copy link
Contributor

@DrexHD DrexHD commented Sep 28, 2024

Check discord for details.
TLDR:

  • Search packet was incorrectly updated during the 1.20.5 update.
  • The entity change action extra data field only stores the item id of items that are used during item changing. This is inconsistent with other actions and causes hovering over the action message to not show item details such as enchants. This has been fixed by storing all item data and if item data can't be parsed falling back to the old format (for de-serialization).

@DrexHD DrexHD requested a review from a team as a code owner September 28, 2024 23:37
@PotatoPresident PotatoPresident merged commit 94ddcae into QuiltServerTools:master Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants